[coreboot-gerrit] Change in coreboot[master]: util: Add spd_tools to generate SPDs for TGL and JSL boards

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41612 )

Change subject: util: Add spd_tools to generate SPDs for TGL and JSL boards
......................................................................

Patch Set 17:

(4 comments)

https://review.coreboot.org/c/coreboot/+/41612/17//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41612/17//COMMIT_MSG@8 
PS17, Line 8: 
Add an introduction stating, that current SPD files are incorrect in some places?

https://review.coreboot.org/c/coreboot/+/41612/17//COMMIT_MSG@12 
PS17, Line 12: JESD209-4C specification and Intel recommendations (doc #616599,
Is there a doc number missing? Closing ) is missing.

From the `README.md`, I’d assume *#610202)*.

https://review.coreboot.org/c/coreboot/+/41612/17/util/spd_tools/intel/lp4x/... 
File util/spd_tools/intel/lp4x/README.md:

https://review.coreboot.org/c/coreboot/+/41612/17/util/spd_tools/intel/lp4x/... 
PS17, Line 255: gen_spd.go
Mark up as code with `x`?

https://review.coreboot.org/c/coreboot/+/41612/17/util/spd_tools/intel/lp4x/... 
PS17, Line 259: board(variant)
I’d add a space before (.