[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/nissa/var/yaviks: Add probe in devicetree for USB C1/A0 port

[Chen Wisley (Code Review)]

Attention is currently required from: Wisley Chen.

Hello Wisley Chen,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/coreboot/+/78175?usp=email

to review the following change.

Change subject: mb/google/nissa/var/yaviks: Add probe in devicetree for USB C1/A0 port
......................................................................

mb/google/nissa/var/yaviks: Add probe in devicetree for USB C1/A0 port

Add probe fw_config to enable/disable USB C1/A0 port for DB_1A sku.

BUG=b:294456574
TEST=emerge-nissa coreboot

Change-Id: I2261b0e4d2b673b6186a435cce8dc6a4ccacb0a7
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/brya/variants/yaviks/overridetree.cb
1 file changed, 17 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/78175/1

diff --git a/src/mainboard/google/brya/variants/yaviks/overridetree.cb b/src/mainboard/google/brya/variants/yaviks/overridetree.cb
index 8c36f7e..308ed10 100644
--- a/src/mainboard/google/brya/variants/yaviks/overridetree.cb
+++ b/src/mainboard/google/brya/variants/yaviks/overridetree.cb
@@ -494,7 +494,11 @@
    				chip drivers/intel/pmc_mux/conn
    					use usb2_port2 as usb2_port
    					use tcss_usb3_port2 as usb3_port
-						device generic 1 alias conn1 on end
+						device generic 1 alias conn1 on
+							probe DB_USB DB_1C_1A
+							probe DB_USB DB_1C
+							probe DB_USB DB_1C_LTE
+						end
    				end
    			end
    		end
@@ -514,7 +518,11 @@
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
                                                 register "use_custom_pld" = "true"
                                                 register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, LEFT, ACPI_PLD_GROUP(2, 1))"
-						device ref tcss_usb3_port2 on end
+						device ref tcss_usb3_port2 on
+							probe DB_USB DB_1C_1A
+							probe DB_USB DB_1C
+							probe DB_USB DB_1C_LTE
+						end
    				end
    			end
    		end
@@ -534,7 +542,11 @@
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
                                                 register "use_custom_pld" = "true"
                                                 register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, LEFT, ACPI_PLD_GROUP(2, 1))"
-						device ref usb2_port2 on end
+						device ref usb2_port2 on
+							probe DB_USB DB_1C_1A
+							probe DB_USB DB_1C
+							probe DB_USB DB_1C_LTE
+						end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Port A0 (MLB)""
@@ -561,6 +573,7 @@
    					register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, RIGHT, ACPI_PLD_GROUP(3, 1))"
    					device ref usb2_port4 on
    						probe DB_USB DB_1C_1A
+							probe DB_USB DB_1A
    					end
    				end
    				chip drivers/usb/acpi
@@ -614,6 +627,7 @@
                                                 register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, RIGHT, ACPI_PLD_GROUP(3, 1))"
    					device ref usb3_port2 on
    						probe DB_USB DB_1C_1A
+							probe DB_USB DB_1A
    					end
    				end
    				chip drivers/usb/acpi