Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38300 )
Change subject: timestamps: Fix TIMESTAMPS_ON_CONSOLE behaviour ......................................................................
timestamps: Fix TIMESTAMPS_ON_CONSOLE behaviour
As logging is guarded by Kconfig, increase the level from BIOS_SPEW to BIOS_INFO.
The original callsite inside timestamp_add_table_entry() was also called when syncing from timestamps from .bss to CBMEM. We should not reprint the values then.
Change-Id: I72ca4b6a04d8734c141a04e651fc8c23932b1f23 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/lib/timestamp.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38300/1
diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c index 7c7210c..d2206f6 100644 --- a/src/lib/timestamp.c +++ b/src/lib/timestamp.c @@ -130,9 +130,6 @@ tse->entry_id = id; tse->entry_stamp = ts_time - ts_table->base_time;
- if (CONFIG(TIMESTAMPS_ON_CONSOLE)) - printk(BIOS_SPEW, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time); - if (ts_table->num_entries == ts_table->max_entries) printk(BIOS_ERR, "ERROR: Timestamp table full\n"); } @@ -152,6 +149,9 @@ }
timestamp_add_table_entry(ts_table, id, ts_time); + + if (CONFIG(TIMESTAMPS_ON_CONSOLE)) + printk(BIOS_INFO, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time); }
void timestamp_add_now(enum timestamp_id id)