Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: intel/common/mmc: Provide mmc.c for setting dll registers. ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35040/2/src/soc/intel/common/block/... File src/soc/intel/common/block/scs/mmc.c:
https://review.coreboot.org/c/coreboot/+/35040/2/src/soc/intel/common/block/... PS2, Line 22: mainboard_get_mmc_dll i would have expect this call to go into soc code and soc code gets required value from chip.h config which might be mainboard specific rather rewriting the same function into each mainboard. I hope chip.h configs should be able to provide mainboard level abstraction into soc code. Thoughts ?
https://review.coreboot.org/c/coreboot/+/35040/2/src/soc/intel/common/block/... PS2, Line 27: ioaddr why you are calling this as ioaddress ? rather calling as BAR ?
https://review.coreboot.org/c/coreboot/+/35040/2/src/soc/intel/common/block/... PS2, Line 27: int why can't be static ?