Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Jamie Ryu, Subrata Banik, Jérémy Compostella, Kapil Porwal, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74796 )
Change subject: soc/intel/cmn/cse: Remove dependency on ME_RW compression for CSE FW sync
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74796/comment/481e02bc_84421595
PS4, Line 10: The change 'commit:Iac37aaa5ede5e1cd: ("Add Kconfigs to indicate
: when CSE FW sync is performed")'
Please look through `git log` how to reference commits. I suggest:
Commit ddd66ed204f4 ("Add Kconfigs to indicate when CSE FW sync is performed") adds support to choose …
https://review.coreboot.org/c/coreboot/+/74796/comment/13986bc3_df8b3e44
PS4, Line 15: removed
removes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ca4e4a993e4c4cc98b8829cbefff00b28e31549
Gerrit-Change-Number: 74796
Gerrit-PatchSet: 4
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 21:50:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment