Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/30884
to review the following change.
Change subject: drivers/spi/amic.c: Add the rest of >=1MB AMIC A25 chips ......................................................................
drivers/spi/amic.c: Add the rest of >=1MB AMIC A25 chips
Required for ACPI S3 suspend support at some motherboards. Synchronizing with flashchips.c/h flashrom source code.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic5bd3e43e0d3fd5f454fae71b307c0682f203d5c --- M src/drivers/spi/amic.c 1 file changed, 64 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/30884/1
diff --git a/src/drivers/spi/amic.c b/src/drivers/spi/amic.c index 64bdab3..b0e926e 100644 --- a/src/drivers/spi/amic.c +++ b/src/drivers/spi/amic.c @@ -42,6 +42,38 @@
static const struct amic_spi_flash_params amic_spi_flash_table[] = { { + .id = 0x2015, + .l2_page_size = 8, + .pages_per_sector = 16, + .sectors_per_block = 16, + .nr_blocks = 32, + .name = "A25L16PU", + }, + { + .id = 0x2025, + .l2_page_size = 8, + .pages_per_sector = 16, + .sectors_per_block = 16, + .nr_blocks = 32, + .name = "A25L16PT", + }, + { + .id = 0x3014, + .l2_page_size = 8, + .pages_per_sector = 16, + .sectors_per_block = 16, + .nr_blocks = 16, + .name = "A25L080", + }, + { + .id = 0x3015, + .l2_page_size = 8, + .pages_per_sector = 16, + .sectors_per_block = 16, + .nr_blocks = 32, + .name = "A25L016", + }, + { .id = 0x3016, .l2_page_size = 8, .pages_per_sector = 16, @@ -49,6 +81,38 @@ .nr_blocks = 64, .name = "A25L032", }, + { + .id = 0x4014, + .l2_page_size = 8, + .pages_per_sector = 16, + .sectors_per_block = 16, + .nr_blocks = 16, + .name = "A25LQ080", + }, + { + .id = 0x4015, + .l2_page_size = 8, + .pages_per_sector = 16, + .sectors_per_block = 16, + .nr_blocks = 32, + .name = "A25LQ16", + }, + { + .id = 0x4016, + .l2_page_size = 8, + .pages_per_sector = 16, + .sectors_per_block = 16, + .nr_blocks = 64, + .name = "A25LQ032", + }, + { + .id = 0x4017, + .l2_page_size = 8, + .pages_per_sector = 16, + .sectors_per_block = 16, + .nr_blocks = 128, + .name = "A25LQ64", + }, };
static int amic_write(const struct spi_flash *flash, u32 offset, size_t len,