Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45654 )
Change subject: soc/intel/cannonlake: Align gpio_op.asl with TGL
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45654/5/src/soc/intel/cannonlake/ac...
File src/soc/intel/cannonlake/acpi/gpio_op.asl:
https://review.coreboot.org/c/coreboot/+/45654/5/src/soc/intel/cannonlake/ac...
PS5, Line 15: PAD_CFG0_RX_STATE & (VAL0 >> PAD_CFG0_RX_STATE_BIT)
make sense, will submit one
https://review.coreboot.org/c/coreboot/+/45738
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78d712eeba56b9c098dc6a6f11e4e51cb2529b10
Gerrit-Change-Number: 45654
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Fri, 25 Sep 2020 14:24:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment