ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )
Change subject: WIP: Add configurable ramstage support for minimal PCI scanning
......................................................................
Patch Set 12:
(1 comment)
Patch Set 11:
(1 comment)
for the read_resources approach, could I do this;
in the standard read_resources, if CONFIG_MINIMAL_PCI_SCANNING is set, I just return
and then add a new function
read_resources_always
which does not test CONFIG_MINIMAL_PCI_SCANNING?
It would be nice to do this without changing the whole tree, at least until we know if it works.
https://review.coreboot.org/c/coreboot/+/36221/11/src/device/pci_device.c
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/36221/11/src/device/pci_device.c@94...
PS11, Line 943: if (CONFIG(MINIMAL_PCI_SCANNING) && driver && !driver->always_scan) {
I think we also want
if (CONFIG(MINIMAL_PCI_SCANNING) && ! driver
dev->enabled = 0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2073d9f8e9297c2b02530821ebb634ea2a5c758e
Gerrit-Change-Number: 36221
Gerrit-PatchSet: 12
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Oct 2019 17:30:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment