Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: soc/intel/skylake: Update GFX devtree options
......................................................................
Patch Set 8:
Patch Set 7: Code-Review-1
IMO, this patch does too much at once to keep track of
everything...
Open questions:
- Why change the PrimaryDisplay setting of h110m?
- Why would we ever set `PrimaryDisplay = Display_Auto` together with `SkipExtGfxScan`?
- If I didn't miss it, the `SkipExtGfxScan` UPD wasn't set before? So this change changes all boards without mentioning it?
- What does `SkipExtGfxScan` do anyway?
Yes, I agree with you about the patch. As a result of all the fixes, it became very large. I reworked it and split it into 4 different patches:
- this patch
- "Set PEG as primary GFX device" Change-Id: Iea846179fc309c2b98093de37c05ceb332081f4f
- "remove unused InternalGfx" Change-Id: I41ecca3fdfb1d4b20ee634a13263ff481dcf440e
- "Update SkipExtGfxScan in UPD from devtree" Change-Id: Ie88a41bdf31f7c3e88df6c70c82a1cbf866372c4
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f9362676105e41c69139a094dbb9e8b865689f
Gerrit-Change-Number: 32044
Gerrit-PatchSet: 8
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Wed, 03 Apr 2019 09:50:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment