[coreboot-gerrit] Change in coreboot[master]: sc7180: QSIP SPI NOR addressing mode

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38542 )

Change subject: sc7180: QSIP SPI NOR addressing mode
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38542/10/src/drivers/spi/spi_flash.... 
File src/drivers/spi/spi_flash.c:

https://review.coreboot.org/c/coreboot/+/38542/10/src/drivers/spi/spi_flash.... 
PS10, Line 515: 		while(1)
> Done

Hi Sajida,

Please read and reply to the comments from Aaron and me early in this patch thread. For now I am not expecting that we'll want to land this patch, so you don't need to spend time cleaning up linter warnings. If you do want to permanently land this patch, we'll need to discuss a different and more complicated approach to do that cleanly in a way that fits in our framework.