Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42142 )
Change subject: [RFC] Move SYSTEM_TYPE_xxx to devicetree.cb
......................................................................
Patch Set 1:
I noticed google/zork pushes fadt_pm_profile into devicetree.cb. I think it would be useful to somehow introduce a top-level config structure, such that we would have a place for some global configuration bytes, independent of soc/chip.h.
Some of these things that end up in FADT at least are just constant values but can vary between variants.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42142
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib546706d04fede6c14ac57280ae72dca4fb7085b
Gerrit-Change-Number: 42142
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jun 2020 17:25:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment