Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38726 )
Change subject: ec/google/chromeec: Enable TCSS port set flag ......................................................................
Patch Set 10:
(7 comments)
https://review.coreboot.org/c/coreboot/+/38726/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38726/6//COMMIT_MSG@7 PS6, Line 7: ec/google/chromeec : Enable TCSS port set flag
Please remove the space before the colon.
Done
https://review.coreboot.org/c/coreboot/+/38726/6//COMMIT_MSG@9 PS6, Line 9: SubSytem
nit: Typo SubSystem
Done
https://review.coreboot.org/c/coreboot/+/38726/6//COMMIT_MSG@10 PS6, Line 10: and
which is updated by coreboot
Done
https://review.coreboot.org/c/coreboot/+/38726/4/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/38726/4/src/ec/google/chromeec/ec.c... PS4, Line 1475: int
uint8_t
Done
https://review.coreboot.org/c/coreboot/+/38726/7/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/38726/7/src/ec/google/chromeec/ec.c... PS7, Line 1490: int rv;
?
Done
https://review.coreboot.org/c/coreboot/+/38726/7/src/ec/google/chromeec/ec.c... PS7, Line 1492: =
?
Done
https://review.coreboot.org/c/coreboot/+/38726/4/src/soc/intel/tigerlake/ear... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/38726/4/src/soc/intel/tigerlake/ear... PS4, Line 181: mux_data.hpd_irq
mux_data.hpd_irq || mux_data. […]
Done