[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cnl: Enable VT-d

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32432 )

Change subject: soc/intel/cnl: Enable VT-d
......................................................................

Patch Set 8: Code-Review+1

(2 comments)

Some final suggestions inline.

https://review.coreboot.org/#/c/32432/8/src/soc/intel/cannonlake/acpi.c 
File src/soc/intel/cannonlake/acpi.c:

https://review.coreboot.org/#/c/32432/8/src/soc/intel/cannonlake/acpi.c@345 
PS8, Line 345: 	acpi_dmar_rmrr_fixup(tmp, current);
Please mention this fix in the commit message.

https://review.coreboot.org/#/c/32432/8/src/soc/intel/common/Kconfig 
File src/soc/intel/common/Kconfig:

https://review.coreboot.org/#/c/32432/8/src/soc/intel/common/Kconfig@65 
PS8, Line 65: config SOC_INTEL_COMMON_VTD
This does nothing so far. Drop it until somebody needs an option to disable
VT-d?