Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34872 )
Change subject: google/kukui: Load and run dram init blob
......................................................................
Patch Set 5:
Patch Set 5:
... on the other hand, it's probably also not a bad idea to put everything into the buffer, say
struct dram_calibration_param {
u32 result;
u32 length;
u8 data[];
}
This may be easier to prevent ABI issues
I think we should do it this way (with struct).
Since we use PROG_RUN(), it passes only one argument to entry.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad05a77e6353f37cd5ea897203d528762f44176e
Gerrit-Change-Number: 34872
Gerrit-PatchSet: 5
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 30 Aug 2019 03:28:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment