Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation ......................................................................
Patch Set 12:
(6 comments)
Please make sure you're marking comments as resolved when you address them. Patches can no longer be merged until all comments are resolved, and while I don't mind marking one as resolved before merging, there are way too many comments in this patch set for anyone to deal with.
https://review.coreboot.org/c/coreboot/+/34662/12/Documentation/binaries/amd... File Documentation/binaries/amd/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/12/Documentation/binaries/amd... PS12, Line 13: have has
https://review.coreboot.org/c/coreboot/+/34662/12/Documentation/binaries/amd... PS12, Line 14: v8 I'm not sure what AGESA v8 was. I think the previous version (for stoney) was Arch2008
https://review.coreboot.org/c/coreboot/+/34662/12/Documentation/binaries/amd... PS12, Line 20: tell tells the
https://review.coreboot.org/c/coreboot/+/34662/12/Documentation/binaries/amd... PS12, Line 35: GESA has some DXE code, FSP does not \ : So required code was moved within AGESA from DXE phase to PEI phase. So this is no longer an FSP difference, right?
https://review.coreboot.org/c/coreboot/+/34662/12/Documentation/binaries/amd... PS12, Line 37: urrently all code is being landed in FSP-M due to AGESA dependencies. : However it's intended that some code will land in FSP-S in the future. If we're initializing PCIe in FSP-S, this is no longer true, correct?
https://review.coreboot.org/c/coreboot/+/34662/12/Documentation/binaries/amd... PS12, Line 45: does remove 'does'