Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40575 )
Change subject: mb/facebook/watson: add variant watson_v2
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40575/8/src/mainboard/facebook/wats...
File src/mainboard/facebook/watson/Kconfig:
https://review.coreboot.org/c/coreboot/+/40575/8/src/mainboard/facebook/wats...
PS8, Line 58: string
Since this is only valid for v2, it might be cleaner to use "depends on" instead of the if condition […]
Done
https://review.coreboot.org/c/coreboot/+/40575/8/src/mainboard/facebook/wats...
File src/mainboard/facebook/watson/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/40575/8/src/mainboard/facebook/wats...
PS8, Line 5: : 2nd variant of Watson microserver
no need to put a description here, "Watson_v1" and "Watson_v2" are enough to know they're different […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40575
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: Iabf4183dfeabb2f9946dbb5c98c60b7c0cdba711
Gerrit-Change-Number: 40575
Gerrit-PatchSet: 8
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen
rgzwen@arista.com
Gerrit-Reviewer: Wei Hu
wei@arista.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 17:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment