Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37532 )
Change subject: northbridge: Don't use both of _ADR and _HID
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37532/2/src/northbridge/amd/pi/0066...
File src/northbridge/amd/pi/00660F01/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/37532/2/src/northbridge/amd/pi/0066...
PS2, Line 19: /* Name(_HID, EISAID("PNP0A08")) // PCI Express Root Bridge */
Why not just removing this line?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48fb3e9e48893336416eb90f80957e5bd21d1711
Gerrit-Change-Number: 37532
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1002701
Gerrit-Reviewer: Name of user not set #1002701
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Dec 2019 09:34:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment