Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44185 )
Change subject: drivers/usb: Replace return value -10 with variable ......................................................................
drivers/usb: Replace return value -10 with variable
Coverity detects that value assigned to variable "ret" is overwritten before it is used. Fix the issue by returning right value.
Found-by: Coverity CID 1255942, 1241836 TEST=None
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I2e1fb5400ff64c6178bb30601896780f8d67b5c6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44185 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/usb/ehci_debug.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Tim Wawrzynczak: Looks good to me, but someone else must approve
diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index 5998172..ab76f3b 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -600,7 +600,7 @@ goto try_next_time; }
- return -10; + return ret; }
static int dbgp_enabled(void)