Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/volte... File util/mainboard/google/volteer/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/volte... PS4, Line 3: ddr4 This still refers to ddr4. Probably say either of the DDR4 or LP4x depending upon the memory type being used by the variant?
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/volte... PS4, Line 4: ddr4 Same here.
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... PS2, Line 5: ddr4
There is no "empty" SPD for lpddr4x. I just need a placeholder here. […]
I think we should add a empty SPD for LP4x in that case. It is confusing that the default used a SPD file referencing DDR4 but the platform really uses LP4x.
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/mem_parts_used.txt:
PS4: Same comments here as for waddledoo.
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... File util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... PS4, Line 4: ddr4 This is still incorrect. Dedede boards do not use DDR4 memory.
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... PS4, Line 9: , Fixed ID (optional) Let's not add this by default. Ideally we should not be using that at all. It can be added if/when a variant really needs it.