Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/18558 )
Change subject: soc/intel/common/block: Add Intel common RTC code support ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/#/c/18558/3/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/rtc.h:
Line 4: * Copyright (C) 2017 Intel Corporation.
(C) missing here.
Done
Line 22
extra line
Done
https://review.coreboot.org/#/c/18558/3/src/soc/intel/common/block/rtc/rtc.c File src/soc/intel/common/block/rtc/rtc.c:
PS3, Line 23: define B_PCH_P
Sounds like you just need an OR by itself instead of having to hard code ~0
Done
PS3, Line 24: fine B_PCH_PCR_RTC_CONF_UC
Either the IP is the same or its not
Done
Line 25: #define B_PCH_PCR_RTC_CONF_RESERVED (1 << 31)
remove this extra line.
Done