Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47835 )
Change subject: mb/clevo/cml-u: Get rid of cnl_configure_pads()
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47835/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47835/3//COMMIT_MSG@9
PS3, Line 9: since is a hack for the FSP
"since >it< is"; also, maybe "since it is a hack for FSP only needed in special cases" is better?
The only "special case" is the FSP here. It configures GPIOs that it shouldn't.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47835
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75dd15ab6d2b3b72b3ad0398df87b349fd00bc3c
Gerrit-Change-Number: 47835
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 22 Nov 2020 20:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment