Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede...
PS8, Line 101: PLTRST
Not tested with S3 Furquan, but since it is set for PLTRST , it would go back to default on PLTRST a […]
Done
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede...
PS8, Line 41: .scl_lcnt = 176,
: .scl_hcnt = 95,
: .sda_hold = 36,
Ok, raised a bug #151302522 to track tuning
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39285
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9
Gerrit-Change-Number: 39285
Gerrit-PatchSet: 15
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Mar 2020 13:41:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment