Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39401 )
Change subject: soc/intel/tigerlake: add support to read spd data from SMBUS ......................................................................
Patch Set 6:
(8 comments)
https://review.coreboot.org/c/coreboot/+/39401/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39401/6//COMMIT_MSG@7 PS6, Line 7: spd SPD
https://review.coreboot.org/c/coreboot/+/39401/6//COMMIT_MSG@7 PS6, Line 7: SMBUS SMBus
https://review.coreboot.org/c/coreboot/+/39401/6//COMMIT_MSG@9 PS6, Line 9: SMBUS SMBus
https://review.coreboot.org/c/coreboot/+/39401/6//COMMIT_MSG@10 PS6, Line 10: data. So, add support to read SPD data from SMBUS Please add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/39401/6//COMMIT_MSG@11 PS6, Line 11: Tested how?
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/meminit_jsl.h:
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/inc... PS6, Line 20: #include <stdint.h> Should be cleaned up in a separate commit.
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/inc... PS6, Line 55: spd SPD
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit_jsl.c:
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/mem... PS6, Line 109: spd_info->spd_spec.spd_smbus_address[i]; Fits into 96 characters?