16 Oct
2019
16 Oct
'19
4:21 a.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35147 )
Change subject: mediatek/mt8183: Allow modifying vdram2 voltage ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35147/12/src/soc/mediatek/mt8183/mt... File src/soc/mediatek/mt8183/mt6358.c:
https://review.coreboot.org/c/coreboot/+/35147/12/src/soc/mediatek/mt8183/mt... PS12, Line 758: (-1)*10000, I'm not sure why we have to write in this form - can we do
-10000, -20000, ... ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35147
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f0d82596a1709bf0d37885f257646133f18f210
Gerrit-Change-Number: 35147
Gerrit-PatchSet: 12
Gerrit-Owner: hsin-hsiung wang hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Ben Ho Ben.Ho@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: huayang duan huayangduan@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Oct 2019 04:21:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment