2 Mar
2021
2 Mar
'21
9:05 a.m.
Attention is currently required from: Furquan Shaikh. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50858 )
Change subject: soc/intel/common: Add function to lpc_lib to return PIRQ routing ......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/lpc_lib.h:
https://review.coreboot.org/c/coreboot/+/50858/comment/5b470838_4b5354a3 PS3, Line 108: lpc_get_pch_pirq_routing
Should we add `legacy` or `pic` in the name to indicate that this is the PIRQ# routing only for PIC/ […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/50858
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib215fba54573c50a88aa4584442bd8d27ae017be
Gerrit-Change-Number: 50858
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 17:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment