Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files
......................................................................
Patch Set 6:
I think it would be helpful to generalize the changes made in the commit msg. Without looking at each file, it's impossible to know what "clean up" means in the context of the commit.
It appears that this change shouldn't result in any difference to a reproducible build for any of the affected boards, which if true should be called out
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a3bffcb0fa0de35480a767a1e3aa323e0591198
Gerrit-Change-Number: 37840
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Dec 2019 17:34:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment