Hello build bot (Jenkins), Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40962
to look at the new patch set (#5).
Change subject: superio/*: Standardise config state entry/exit prototype in pnp_ops.h ......................................................................
superio/*: Standardise config state entry/exit prototype in pnp_ops.h
pnp_{entry,exit}_conf_state() is declared and implemented under each super I/O with not that much variation. Move the identical prototypes to a central location along with other pre-RAM pnp functions.
All code that use pre-RAM pnp include pnp_ops.h and all basic functions will be brought in. The correct implementation is selected at compile time via Makefile.inc.
This provides a standard pre-RAM PNP API, with the eventual goal of consolidating all implementations, with only one implementation per actual known config state entry/exit sequence.
TEST=abuild
Change-Id: If4e742edb17ca73c01ff7b552e00e18acc6779dd Signed-off-by: Keith Hui buurin@gmail.com --- M src/ec/google/wilco/bootblock.c M src/include/device/pnp_ops.h M src/superio/aspeed/common/aspeed.h M src/superio/fintek/common/fintek.h M src/superio/ite/common/ite.h M src/superio/smsc/kbc1100/early_init.c M src/superio/smsc/lpc47m10x/lpc47m10x.h M src/superio/smsc/lpc47m15x/early_serial.c M src/superio/smsc/lpc47n217/early_serial.c M src/superio/smsc/lpc47n227/lpc47n227.h M src/superio/smsc/smscsuperio/early_serial.c M src/superio/winbond/common/winbond.h 12 files changed, 13 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/40962/5