Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... PS5, Line 426: dl
Hi Tim, Furquan, shall I back up into edi and restore? what do you suggest is right thing to do here […]
What about the sequence I posted above? ``` mov $0x01, %eax shl %cl, %eax shl %cl, %eax subl $0x01, %eax ```
just do the shifting using the value from %cl two times instead of bothering with the multiply; this doesn't require modifying %eax or backing it up
https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... PS5, Line 435: /* : * Program MSR 0x1892 IA32_CR_SF_QOS_MASK_2 with : * total number of LLC ways : */ : movl $IA32_CR_SF_QOS_MASK_2, %ecx : xorl %edx, %edx : wrmsr
Do you both suggest this is ok?
The most authoritative info we have is from the document Shyam sent us; it said: ``` IA32_L3_SF_MASK_2 can be left to reset default. [To be updated with additional information] ```
so I guess I would just not program it