Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34289 )
Change subject: soc/intel/cannonlake: Split the "internal PME" wake-up into more detail
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34289/4/src/soc/intel/cannonlake/el...
File src/soc/intel/cannonlake/elog.c:
https://review.coreboot.org/c/coreboot/+/34289/4/src/soc/intel/cannonlake/el...
PS4, Line 73: // register is at offset 0xCC.
Nit: Not sure if we should stick to C style comments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34289
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c71f6a56b4e1658a7427f67fa78af773b97ec7f
Gerrit-Change-Number: 34289
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jul 2019 20:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment