build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32083 )
Change subject: payload/libpayload: This is a fixe for potential NULL pointer dereferences ......................................................................
Patch Set 1:
(26 comments)
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ehci... File payloads/libpayload/drivers/usb/ehci.c:
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ehci... PS1, Line 638: fatal("Not enough memory to create #reqcount transfer descriptors. \n"); line over 80 characters
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ehci... PS1, Line 638: fatal("Not enough memory to create #reqcount transfer descriptors. \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ehci... PS1, Line 648: usb_debug("Not enough memory to add transfer descriptor. \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ehci... PS1, Line 662: fatal("Not enough memory to create spare transfer descriptors.\n"); line over 80 characters
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ehci... PS1, Line 843: periodic_list[i] = virt_to_phys(EHCI_INST(controller)->dummy_qh) line over 80 characters
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ehci... PS1, Line 849: trailing whitespace
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 215: if (!OHCI_INST(controller)->hcca) suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 228: if (!periodic_ed) suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 229: fatal("Not enough DMA memory for OHCI interrupt table .\n"); line over 80 characters
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 385: if (!first_td) suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 386: fatal("Not enough DMA memory for OHCI first TD in buffer.\n"); line over 80 characters
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 437: if (!next_td) suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 438: fatal("Not enough DMA memory for OHCI additional TD.\n"); line over 80 characters
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 464: if (!head) suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 465: fatal("Not enough DMA memory for OHCI data structures.\n"); line over 80 characters
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 538: if (!first_td) suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 539: fatal("Not enough DMA memory for OHCI first TD of bulk transfer.\n"); line over 80 characters
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 594: if (!head) suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 595: fatal("Not enough DMA memory for OHCI bulk transfer's head.\n"); line over 80 characters
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 693: usb_debug("Not enough DMA memory for intr queue \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 707: usb_debug("Not enough memory to add transfer descriptor. \n"); code indent should use tabs where possible
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 707: usb_debug("Not enough memory to add transfer descriptor. \n"); please, no space before tabs
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 707: usb_debug("Not enough memory to add transfer descriptor. \n"); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 707: usb_debug("Not enough memory to add transfer descriptor. \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 730: usb_debug("Not enough memory to add dummy TD. \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/32083/1/payloads/libpayload/drivers/usb/ohci... PS1, Line 733: trailing whitespace