Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37706/4/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37706/4/Makefile.inc@100
PS4, Line 100: subdirs-$(CONFIG_MAINBOARD_INTEL_COMMON) += src/mainboard/intel/common
This does not belong here. It should be part of individual mainboards that use common definitions just like how cpu/intel/common subdir is included in individual SoCs
eg.
subdirs-y += ../../../cpu/intel/common
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb104a1baeacc742abe9e4f46e39d41f2da96c5a
Gerrit-Change-Number: 37706
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Dec 2019 07:05:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment