Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45951 )
Change subject: soc/intel: deduplicate ACPI timer emulation ......................................................................
Patch Set 18:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/alderlake/cp... File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/alderlake/cp... PS17, Line 148: if ACPI PM timer is disabled
Will need in update if we decide to drop the condition.
There is no condition anymore
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/apollolake/M... File src/soc/intel/apollolake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/apollolake/M... PS17, Line 13: ../../soc/intel/
err, why is it done in the bootblock? We might want to move it later.
That's a very good question. In APL it is done 1) in early core init in bootblock AND 2) in core init in ramstage
The code in APL mentions this in cpu.c, maybe that is the reason it's also done in early init: " Enable ACPI PM timer emulation, which also lets microcode know location of ACPI_BASE_ADDRESS. This also enables other features implemented in microcode."
Would be good to know, *what* features that are and if other platforms need this, too in early cpu init... Andrey, Furquan, Subrata: any idea?