Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl ......................................................................
Patch Set 17: Code-Review+1
(2 comments)
looks good to me, but i currently don't have the time to check the register names and offsets, so I'm a bit hesitant to hit +2. if someone else wants to do that, please go ahead
https://review.coreboot.org/c/coreboot/+/35189/17/util/inteltool/lpc.c File util/inteltool/lpc.c:
https://review.coreboot.org/c/coreboot/+/35189/17/util/inteltool/lpc.c@111 PS17, Line 111: 0xDC use a define for this? also coreboot uses mostly lower case for hex values
https://review.coreboot.org/c/coreboot/+/35189/17/util/inteltool/powermgt.c File util/inteltool/powermgt.c:
https://review.coreboot.org/c/coreboot/+/35189/17/util/inteltool/powermgt.c@... PS17, Line 880: case 0x1234: // Dummy for non-existent functionality : printf("This southbridge does not have PMBASE.\n"); : return 1; this can be removed