Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, Patrick Rudolph, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57035 )
Change subject: soc/intel/alderlake: set power limits dynamically for thermal ......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/alderlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/57035/comment/79377a67_4bef5777 PS3, Line 76: tdp = get_cpu_tdp(); This is only used for the ADL_P_ID_3, so I think it should just be called there, not for all sa_pci_id
https://review.coreboot.org/c/coreboot/+/57035/comment/1e1cf45b_b59477e8 PS3, Line 89: soc_config = &config->power_limits_config[ADL_P_POWER_LIMITS_682_28W_CORE];
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/57035/comment/d4a5f1a0_5bcc701b PS3, Line 91: soc_config = &config->power_limits_config[ADL_P_POWER_LIMITS_682_45W_CORE];
line over 96 characters
Please fix.