[coreboot-gerrit] [M] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP 2.4 64-bits

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Arthur Heymans, Bora Guvendik, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Shuo Liu, Tim Chu, Wonkyu Kim.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80277?usp=email )

Change subject: drivers/intel/fsp2_0: Support FSP 2.4 64-bits
......................................................................

Patch Set 30:

(2 comments)

File src/include/efi/efi_datatype.h:

https://review.coreboot.org/c/coreboot/+/80277/comment/cf1c7927_a55594db :
PS30, Line 7: /*
            :  * EDK2 EFIAPI macro definition relies on compiler flags such as __GNUC__ which
            :  * is not working well when included by coreboot. While it has no side-effect on
            :  * i386 because the C calling convention used by coreboot and FSP are the same,
            :  * it breaks on x86_64 because FSP/UEFI uses the Microsoft x64 calling
            :  * convention while coreboot uses the System V AMD64 ABI.
            :  *
            :  * Fortunately, EDK2 header allows to override EFIAPI.
            :  */
            : #if CONFIG(PLATFORM_USES_FSP2_X86_32)
            : #define EFIAPI __attribute__((regparm(0)))
            : #else
            : #define EFIAPI __attribute__((__ms_abi__))
            : #endif
            : 
can you please submit this as a separate CL to start with ?

https://review.coreboot.org/c/coreboot/+/80277/comment/15eaf4a5_0969bf76 :
PS30, Line 90: /* EFI function calling convention attribute */
             : #define __efiapi EFIAPI
keep this part of the above CL.