Attention is currently required from: Patrick Georgi, Julius Werner.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59494 )
Change subject: libpayload/libc/fmap: Implement new FlashMap API
......................................................................
Patch Set 4:
(1 comment)
File payloads/libpayload/include/fmap.h:
https://review.coreboot.org/c/coreboot/+/59494/comment/0f8286e4_61a8eea6
PS4, Line 6: #include <commonlib/bsd/cb_err.h>
Before using commonlib in exported headers, you'll also need to ensure that libpayload-using payload […]
Done in CB:59916. Let's continnue discussion there. I will leave this comment open until CB:59916 is merged or solved in another way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbf9016ce73aa58e17f3ee19920ab83dc6c25abb
Gerrit-Change-Number: 59494
Gerrit-PatchSet: 4
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 06 Dec 2021 13:56:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Gerrit-MessageType: comment