Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44035 )
Change subject: sconfig: Switch to getopt
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44035/2/util/sconfig/main.c
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/44035/2/util/sconfig/main.c@1314
PS2, Line 1314: printf(" -c | --output_c : Output static.c file (required)\n");
: printf(" -r | --output_h : Header static.h file (required)\n");
: printf(" -m | --mainboard_devtree : Mainboard devicetree file (required)\n");
: printf(" -o | --override_devtree : Override devicetree file (optional)\n");
These are *paths* to files, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I431633781e80362e086c000b7108191b5b01aa9d
Gerrit-Change-Number: 44035
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 02 Sep 2020 14:48:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment