Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39692 )
Change subject: [WIP]soc/intel/cfl: Try to enable Intel DCI
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39692/1/src/soc/intel/cannonlake/bo...
File src/soc/intel/cannonlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/39692/1/src/soc/intel/cannonlake/bo...
PS1, Line 108: if (enable)
nit: maybe add a debug print to see if DCI gets enabled?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c8bf7e82116bc44430f4be4498f2e445f904886
Gerrit-Change-Number: 39692
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 21 Mar 2020 10:33:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment