Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )
Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also. ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/#/c/32087/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32087/6//COMMIT_MSG@10 PS6, Line 10: This will allow qemu to setup cbmem, and allow VPD variables to be accessible how does ssdt and cbmem affect VPD?
https://review.coreboot.org/#/c/32087/6/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/#/c/32087/6/src/mainboard/emulation/qemu-i440fx/... PS6, Line 25: please no unrelated changes
https://review.coreboot.org/#/c/32087/6/src/mainboard/emulation/qemu-q35/Kco... File src/mainboard/emulation/qemu-q35/Kconfig:
https://review.coreboot.org/#/c/32087/6/src/mainboard/emulation/qemu-q35/Kco... PS6, Line 57: config FMDFILE should be part of the commit introducing the fmap