Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49056 )
Change subject: [TEST] abuild: Default to !CHROMEOS
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49056/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/49056/4//COMMIT_MSG@7
PS4, Line 7: [TEST]
can probably drop now?
Is this supposed to be submitted? I'm kinda confused as to the point of this patch, isn't !CHROMEOS already the default? I think all this would do is to change the specific builds in configs/ that manually set CONFIG_CHROMEOS=y, but do we actually want that? And if we want that, why not just change the config files themselves rather than doing this roundabout thing?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49056
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ae4bc22f70be5b8d8efa35f0cc8aa2d36a5531a
Gerrit-Change-Number: 49056
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Jan 2021 23:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment