Attention is currently required from: Jonathan Zhang, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67018 )
Change subject: device/allocator: Allow for multiple domain resources of a type ......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67018/comment/7390f543_0c0206d9 PS6, Line 11: bridge devices Above it's domains, here bridge devices in general oO So far I don't understand why we should change something for all bridge resources and not only the domains. If it was only done to keep the code for domain and bridge resources aligned, CB:65420 tries to detangle them anyway (it used to be next in the relation chain right after the one we had to revert :-/).
File src/device/resource_allocator_v4.c:
https://review.coreboot.org/c/coreboot/+/67018/comment/3b140d4e_20e2164f PS6, Line 178: update_bridge_resource(bridge, res, type_match, print_depth); In there we'll filter child resources based on the type. If we had multiple bridge resources of the same type, we'd account for every child resource multiple times?