Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama
......................................................................
Patch Set 30:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG@7
PS30, Line 7: add
Capitalize
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG@9
PS30, Line 9: following
the following
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG@9
PS30, Line 9: panels
panel
https://review.coreboot.org/c/coreboot/+/34505/30/src/mainboard/google/kukui...
File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/30/src/mainboard/google/kukui...
PS30, Line 36: {INIT_DCS_CMD, 2, { 0xB0, 0x05 } },
Consider using _INIT_DCS_CMD (added in https://review.coreboot.org/c/coreboot/+/32511/29).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34505
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa
Gerrit-Change-Number: 34505
Gerrit-PatchSet: 30
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicolas Boichat
drinkcat@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Aug 2019 03:36:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment