Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39865 )
Change subject: soc/intel/tigerlake: Reorganize memory initialization support
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39865/7/src/soc/intel/tigerlake/mem...
File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39865/7/src/soc/intel/tigerlake/mem...
PS7, Line 212: }
How about structuring this as if/else if/else or a switch? […]
Makes sense. I will update this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib625f2ab30a6e1362a310d9abb3f2051f85c3013
Gerrit-Change-Number: 39865
Gerrit-PatchSet: 7
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Mar 2020 16:47:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment