Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46141 )
Change subject: soc/intel/common: Add PCI driver for USB4 ports ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46141/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46141/7//COMMIT_MSG@7 PS7, Line 7: USB4 ports
Isn't this really the DMA controller for USB4/TBT?
Yeah, naming things is hard :( I'll add that in.
https://review.coreboot.org/c/coreboot/+/46141/7/src/soc/intel/common/block/... File src/soc/intel/common/block/usb4/Kconfig:
https://review.coreboot.org/c/coreboot/+/46141/7/src/soc/intel/common/block/... PS7, Line 6: Thunderbolt/USB4 ports
This is really just the DMA component, right?
ditto.
https://review.coreboot.org/c/coreboot/+/46141/7/src/soc/intel/common/block/... File src/soc/intel/common/block/usb4/usb4.c:
https://review.coreboot.org/c/coreboot/+/46141/7/src/soc/intel/common/block/... PS7, Line 18: .ops_pci = &pci_dev_ops_pci,
nit: We should also add `.acpi_name` support here. […]
+1, done.