Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 4:
(2 comments)
only had a very brief look and didn't verify any of the registers and values
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c@... PS4, Line 571: the indentations here should be tabs to be consistent with the existing code
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c@... PS4, Line 597: {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}}, i'd expect some of the registers to be the gpio input registers. if you know which ones those are, it would be good to mark them as NANA like it's done for NCT5539D below; if not, just keep it the way it is now and mark this one as resolved. same for the other GPIO LDNs