[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/skyrim: Remove elog_gsmi_cb_mainboard_log_wake_source

[Raul Rangel (Code Review)]

Raul Rangel has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67184 )

Change subject: mb/google/skyrim: Remove elog_gsmi_cb_mainboard_log_wake_source
......................................................................

mb/google/skyrim: Remove elog_gsmi_cb_mainboard_log_wake_source

elog_gsmi_cb_mainboard_log_wake_source is called from SMI and causes
eSPI transactions. If the SMI interrupts an ongoing eSPI transaction
from the OS it will conflict and cause failures. Removing this call to
avoid conflicts. This can be re-enabled after refactoring
google_chromeec_get_mask to use ACPI MMIO.

This is a copy of CB:63280 but for skyrim.

BUG=b:227163985, b:243557044
TEST=suspend/resume skyrim and no longer see EC wake sources in elog.

Signed-off-by: Raul E Rangel 
Change-Id: Iac56840fe15101bc556d8cce9960f761c6ea7181
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67184
Tested-by: build bot (Jenkins) 
Reviewed-by: Jon Murphy 
---
M src/mainboard/google/skyrim/variants/baseboard/smihandler.c
1 file changed, 24 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Jon Murphy: Looks good to me, approved

diff --git a/src/mainboard/google/skyrim/variants/baseboard/smihandler.c b/src/mainboard/google/skyrim/variants/baseboard/smihandler.c
index ef26a42..dcc19f3 100644
--- a/src/mainboard/google/skyrim/variants/baseboard/smihandler.c
+++ b/src/mainboard/google/skyrim/variants/baseboard/smihandler.c
@@ -26,8 +26,3 @@

return 0;
 }
-
-void elog_gsmi_cb_mainboard_log_wake_source(void)
-{
-	google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S0IX_WAKE_EVENTS);
-}