Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31131 )
Change subject: soc/intel/apollolake: Sync fsp upd structure update
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31131/2/src/soc/intel/apollolake/chip.h
File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/#/c/31131/2/src/soc/intel/apollolake/chip.h@173
PS2, Line 173: * value. Default is 0 to not changing default IF value.
The change is sync to fsp 2.0.9 upd update. […]
I mean what are the values that any mainboard user can set for these fields? Mainboard can have an explanation of any specific value that is chosen. But these fields should provide some help on what is the set of valid values that can be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d17dfbe58bdc5222378459723da8e9ac0573510
Gerrit-Change-Number: 31131
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Jan 2019 02:56:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment