[coreboot-gerrit] [S] Change in coreboot[master]: protectcli/vault_bsw: Drop USB power control bits in GNVS

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74859 )

Change subject: protectcli/vault_bsw: Drop USB power control bits in GNVS
......................................................................

protectcli/vault_bsw: Drop USB power control bits in GNVS

There is no platform-level implementation for USB port power management
in various sleepstates. This mainboard never evaluates the set GNVS
variables S3U0, S3U1, S5U0 and S5U1 in ASL or in its SMI handlers.

Change-Id: Ic7af2d608d95c6691f31ef1b8af72f96da20787c
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74859
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
---
M src/mainboard/protectli/vault_bsw/acpi_tables.c
1 file changed, 18 insertions(+), 10 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

diff --git a/src/mainboard/protectli/vault_bsw/acpi_tables.c b/src/mainboard/protectli/vault_bsw/acpi_tables.c
index 4206cde..4276be7 100644
--- a/src/mainboard/protectli/vault_bsw/acpi_tables.c
+++ b/src/mainboard/protectli/vault_bsw/acpi_tables.c
@@ -1,15 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */

-#include <acpi/acpi_gnvs.h>
-#include <soc/acpi.h>
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
-	/* Enable USB ports in S3 */
-	gnvs->s3u0 = 1;
-	gnvs->s3u1 = 1;
-}
+#include <acpi/acpi.h>

void mainboard_fill_fadt(acpi_fadt_t *fadt)
 {