Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44815 )
Change subject: util/ifdtool: Identify chipset without platform name
......................................................................
Patch Set 5:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44815/comment/931d398f_d704f3a7
PS5, Line 199: temp_chipset = guess_ifd_2_chipset(fpsba);
This assumes that the IFD is IFD2. […]
oops 😞
mostly because of https://review.coreboot.org/c/coreboot/+/44815/5/util/ifdtool/ifdtool.c#173 line.
Can you please check if is_platform_ifd_2() check can help prior calling guess_ifd_2_chipset?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44815
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83763adb721e069343b19a10e503975ffa6abb24
Gerrit-Change-Number: 44815
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 12 May 2021 09:44:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment