Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46056 )
Change subject: acpi/device: Add GPIO binding property for an array of GPIOs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46056/1/src/include/acpi/acpi_devic...
File src/include/acpi/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/46056/1/src/include/acpi/acpi_devic...
PS1, Line 550: pin
We do support adding a gpio into _CRS with multiple pins (https://review.coreboot. […]
I guess that would complicate the easy re-use of this array method in the single use method...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46056
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c6cc36b1bfca2d48c84f169e6b43fd4be8ba330
Gerrit-Change-Number: 46056
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Oct 2020 19:27:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment